Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't shade packetevents #114

Open
vytskalt opened this issue Sep 5, 2023 · 3 comments
Open

Don't shade packetevents #114

vytskalt opened this issue Sep 5, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@vytskalt
Copy link
Contributor

vytskalt commented Sep 5, 2023

I think it would be great if packetevents wasn't shaded in the library and it was up to the user to do so. In my case I already depend on ProtocolLib in my plugin so I don't need packetevents to be included.

@derklaro
Copy link
Collaborator

derklaro commented Oct 5, 2023

I will try to take a look into publishing a version with and one without packetevents shaded soon-ish.

@derklaro derklaro added the enhancement New feature or request label Oct 5, 2023
@portlek
Copy link

portlek commented Oct 6, 2023

@derklaro you can split the packetevents implementation into another module so people can still use that with adding new module's dependency.

@vytskalt
Copy link
Contributor Author

vytskalt commented Oct 6, 2023

Or it could use compileOnly on packetevents and then check at runtime if packetevents is in the classpath. This way it would also be possible to use the standalone packetevents plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants