Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple lines #56

Open
unldenis opened this issue Jan 2, 2022 · 4 comments
Open

Multiple lines #56

unldenis opened this issue Jan 2, 2022 · 4 comments

Comments

@unldenis
Copy link

unldenis commented Jan 2, 2022

Hi, I had in mind to add the availability of having an NPC name with more lines.

So I initially forked the project and started working on it. After that I realized that maybe it was better to have it in a different repository so that I can use it myself as a library in my plugins.

So I made Hologram-Lib, a library that allows you to create holograms (even with items and animations) with packets using ProtocolLib.

If interested I can do a PR to implement my library to create the npcs.

@lbirkert
Copy link

lbirkert commented Jan 5, 2022

You cannot make the player name longer then 16 characters or the clients will disconnect

@unldenis
Copy link
Author

unldenis commented Jan 5, 2022

It has nothing to do with the title or even with what I wrote

You cannot make the player name longer then 16 characters or the clients will disconnect

@juliarn
Copy link
Owner

juliarn commented Jan 6, 2022

Hey, very cool project! Altough it isn't really related to npcs, I still think that it might be useful if it is directly implemented into the lib. But I'm not exactly sure yet about the best way it could be integrated.

@unldenis
Copy link
Author

unldenis commented Jan 6, 2022

Yes I had started thinking about it, and the first thing is that I myself use a method in the HologramPool that every 2 ticks does the same job as NpcPool and should share same seeing players etc. So I had in mind to implement the holograms for each npc without the pool, and make public the 'show' and 'hide' methods of the holograms since they are protected at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants