Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite MOI.copy_to to simplify and fix various bugs #184

Merged
merged 1 commit into from
May 30, 2021
Merged

Conversation

odow
Copy link
Member

@odow odow commented May 30, 2021

JuMP docs in jump-dev/JuMP.jl#2610 were still failing, which identified a few other bugs that #183 didn't catch.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #184 (86bf4ce) into master (18f38bf) will decrease coverage by 0.06%.
The diff coverage is 96.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   82.67%   82.60%   -0.07%     
==========================================
  Files           9        9              
  Lines        1685     1644      -41     
==========================================
- Hits         1393     1358      -35     
+ Misses        292      286       -6     
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_copy.jl 97.41% <96.90%> (+1.23%) ⬆️
src/MOI_wrapper/MOI_wrapper.jl 92.43% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f38bf...86bf4ce. Read the comment docs.

@odow odow merged commit 51c6573 into master May 30, 2021
@odow odow deleted the od/fix-copy2 branch May 30, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant