Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compat] BenchmarkTools v1 #1364

Closed
Azzaare opened this issue May 22, 2021 · 5 comments
Closed

[Compat] BenchmarkTools v1 #1364

Azzaare opened this issue May 22, 2021 · 5 comments
Labels
backport 0.9

Comments

@Azzaare
Copy link

Azzaare commented May 22, 2021

Would it be possible to add the compat for BenchmarkTools.jl v1 and tag a new version of MOI?
@blegat
Copy link
Member

blegat commented May 22, 2021

I just did ] up and Pkg downgraded 22 packages just to update BenchmarkTools to v1.0

@odow
Copy link
Member

odow commented May 23, 2021

@blegat looks like quite a few solvers broke: https://github.com/jump-dev/SolverTests/runs/2646391301.

Can we simplify the release-0.9 branch to only include the BenchmarkTools patch?

x-ref: 7674393#r51199237

@blegat
Copy link
Member

blegat commented May 23, 2021

We should at least fix the regressions introduced in v0.9.21 so we need the bug fixes (#1354, #1367) and perf fixes (#1318)

@odow
Copy link
Member

odow commented May 24, 2021

0.9.22 is released.

@odow odow closed this as completed May 24, 2021
@Azzaare
Copy link
Author

Azzaare commented May 24, 2021

Thanks @odow , that was quick :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 0.9
Milestone
No milestone
Development

No branches or pull requests
3 participants
@blegat @Azzaare @odow