Add identity_index_map and fix DoubleDict bug #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
May 10, 2021
| @@ -417,7 +417,9 @@ end | |||
| end | |||
|
|
|||
| function initialize_inner!(d::AbstractWithType{F,S,V,D}) where {F,S,V,D} | |||
| return d.inner = D() | |||
| d.inner = D() | |||
| d.dict.dict[(F, S)] = d.inner | |||
There was a problem hiding this comment.
Ah. I ran into this with the NL writer, but I assumed it was expected behavior.
odow
reviewed
May 10, 2021
odow
reviewed
May 11, 2021
| index_map[ci] = ci | ||
| end | ||
| end | ||
| function identity_index_map(model::MOI.ModelLike) |
There was a problem hiding this comment.
Is every solver going to need to do this?
https://github.com/jump-dev/Clp.jl/pull/111/files#diff-18c6af231f3facc5ba10dd45231da349efda22ecd8d68a4661dee8027bc413a7R302
If so, it needs a docstring and to be added to the documentation.
There was a problem hiding this comment.
Yes, I expect it to be used a lot. I can add docstring :)
odow
approved these changes
May 12, 2021
blegat
force-pushed
the
bl/identity_index_map
branch
from
b4b7511 to
5820e4f
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for jump-dev/Clp.jl#111