Minor refactor with _is_sum #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 89.51% 89.60% +0.08%
==========================================
Files 23 23
Lines 2137 2154 +17
==========================================
+ Hits 1913 1930 +17
Misses 224 224
☔ View full report in Codecov by Sentry. |
odow
reviewed
Oct 11, 2023
| @@ -69,7 +69,7 @@ function _rewrite_generic(stack::Expr, expr::Expr) | |||
| # If the first argument is a splat. | |||
| return esc(expr), false | |||
| elseif _is_generator(expr) || _is_flatten(expr) || _is_parameters(expr) | |||
| if !(expr.args[1] in (:sum, :Σ, :∑)) | |||
| if !_is_sum(expr.args[1]) | |||
There was a problem hiding this comment.
I think I wrote this explicitly because _is_sum was in rewrite.jl, and because it was a bit opaque exactly what we supported here.
|
Closing as won't fix for now. This was intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.