Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird break #47

Closed
itchyny opened this issue Dec 1, 2014 · 5 comments
Closed

weird break #47

itchyny opened this issue Dec 1, 2014 · 5 comments

Comments

@itchyny
Copy link

itchyny commented Dec 1, 2014

I found a break at autoload/easy_align.vim line 846, without while or for statement.

@junegunn
Copy link
Owner

junegunn commented Dec 1, 2014

Ha, thanks for pointing it out. It looks like the line is dead code that's never executed due to the prior condition: https://github.com/junegunn/vim-easy-align/blob/master/autoload/easy_align.vim#L926-L927

@itchyny
Copy link
Author

itchyny commented Dec 1, 2014

You will leave syntax error codes because they are unreachable?

@junegunn
Copy link
Owner

junegunn commented Dec 1, 2014

Of course not :)
I'm at work now and onto something.

@junegunn
Copy link
Owner

junegunn commented Dec 1, 2014

Removed the line. Thanks. Are you reviewing the code? This was my first non-trivial Vim plugin, so I presume you'll find lots of non-idiomatic code lurking in there! ;)

@itchyny
Copy link
Author

itchyny commented Dec 1, 2014

I'm reading codes of some plugins. Before reading I always run vimlint (https://github.com/syngan/vim-vimlint) through all the codes of that plugin. But be glad, this is the only fatal mistake that vimlint warned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants