Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to @ParameterizedTest support classes in the user guide #3673

Closed
eliasnogueira opened this issue Feb 4, 2024 · 0 comments
Closed

Comments

@eliasnogueira
Copy link
Contributor

The issue

There are three broken links in the user guides.

Section Item Cause
2.16.3. Sources of Arguments ValueArgumentsProvider link It is referring to its Javadoc, but the class is private-package
2.16.3. Sources of Arguments CsvArgumentsProvider link It is referring to its Javadoc, but the class is private-package
2.16.4. Argument Conversion AnnotationBasedArgumentConverter link It is referring to the provider package, but the correct is the converter one

Steps to reproduce

  1. Click on the "section" link from the table above
  2. Find the mentioned Item link
  3. Click on it

Proposed solution

As the ValueArgumentsProvider and the CsvArgumentsProvider classes are package-private, not being generated by the JavaDoc the solution is to redirect the reader to its source code.

For the AnnotationBasedArgumentConverter link, only the package change is sufficient.

@marcphilipp marcphilipp added this to the 5.11 M1 milestone Feb 4, 2024
@sbrannen sbrannen changed the title A few broken link in the user guide Fix broken links in the user guide Feb 4, 2024
@sbrannen sbrannen changed the title Fix broken links in the user guide Fix links to @ParameterizedTest support classes in the user guide Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants