Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Stop the page from rendering on scroll #55

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Apr 19, 2023

See #31

Before:
image

After:
image

@rowanc1
Copy link
Member Author

rowanc1 commented Apr 19, 2023

@stevejpurves -- to merge this in we will need to rebase your thebe changes on the book theme (on the dev branch). I think it is good, tested locally -- might be off by a few pixels but the actual page doesn't render which is the bug!

@rowanc1 rowanc1 mentioned this pull request Apr 19, 2023
4 tasks
@rowanc1 rowanc1 merged commit 8af808b into main Apr 19, 2023
@rowanc1 rowanc1 deleted the feat/height-render branch April 19, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant