Windows with Node 16 install fails on CI

[krassowski]

Installing node-gyp seems to be quite resource-intensive and to fail frequently on Windows.

Most recently the windows-latest image switching to windows-2022 (from windows-2019) caused the failure which affects us too. It is due to VisualStudio 2022 as described in nodejs/node-gyp#2520. hashicorp/terraform-cdk#1564 noticed that it is a lerna dependency and that lerna did not pull the fix yet. Lerna's low-activity/maintenance mode keeps maintaining CI green a challenge indeed.

One way to solve it would be via overrides in package.json.

[4/4] Building fresh packages...
error D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3: Command failed.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Exit code: 1
Command: node-pre-gyp install --fallback-to-build
Arguments: 
Directory: D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3
Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.11.0
node-pre-gyp info using node@16.13.2 | win32 | x64
node-pre-gyp WARN Using request for node-pre-gyp https download 
node-pre-gyp info check checked for "D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3\lib\binding\node-v93-win32-x64\node_sqlite3.node" (not found)
node-pre-gyp http GET https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.2.0/node-v93-win32-x64.tar.gz
node-pre-gyp http 403 https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.2.0/node-v93-win32-x64.tar.gz
node-pre-gyp WARN Tried to download(403): https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.2.0/node-v93-win32-x64.tar.gz 
node-pre-gyp WARN Pre-built binaries not found for sqlite3@4.2.0 and node@16.13.2 (node-v93 ABI, unknown) (falling back to source compile with node-gyp) 
node-pre-gyp http 403 status code downloading tarball https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.2.0/node-v93-win32-x64.tar.gz 
gyp info it worked if it ends with ok
gyp info using node-gyp@5.1.1
gyp info using node@16.13.2 | win32 | x64
gyp info ok 
gyp info it worked if it ends with ok
gyp info using node-gyp@5.1.1
gyp info using node@16.13.2 | win32 | x64
gyp info find Python using Python version 3.10.2 found at "C:\Miniconda3\envs\test\python.exe"
gyp http GET https://nodejs.org/download/release/v16.13.2/node-v16.13.2-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v16.13.2/node-v16.13.2-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v16.13.2/SHASUMS256.txt
gyp http GET https://nodejs.org/download/release/v16.13.2/win-x86/node.lib
gyp http GET https://nodejs.org/download/release/v16.13.2/win-x64/node.lib
gyp http GET https://nodejs.org/download/release/v16.13.2/win-arm64/node.lib
gyp http 404 https://nodejs.org/download/release/v16.13.2/win-arm64/node.lib
gyp http 200 https://nodejs.org/download/release/v16.13.2/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/release/v16.13.2/win-x86/node.lib
gyp http 200 https://nodejs.org/download/release/v16.13.2/win-x64/node.lib
gyp ERR! find VS 
gyp ERR! find VS msvs_version not set from command line or npm config
gyp ERR! find VS VCINSTALLDIR not set, not running in VS Command Prompt
gyp ERR! find VS unknown version "undefined" found at "C:\Program Files\Microsoft Visual Studio\2022\Enterprise"
gyp ERR! find VS could not find a version of Visual Studio [201](https://github.com/jupyter-lsp/jupyterlab-lsp/runs/5439917867?check_suite_focus=true#step:17:201)7 or newer to use
gyp ERR! find VS looking for Visual Studio 2015
gyp ERR! find VS - not found
gyp ERR! find VS not looking for VS2013 as it is only supported up to Node.js 8
gyp ERR! find VS 
gyp ERR! find VS **************************************************************
gyp ERR! find VS You need to install the latest version of Visual Studio
gyp ERR! find VS including the "Desktop development with C++" workload.
gyp ERR! find VS For more information consult the documentation at:
gyp ERR! find VS https://github.com/nodejs/node-gyp#on-windows
gyp ERR! find VS **************************************************************
gyp ERR! find VS 
gyp ERR! configure error 
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\find-visualstudio.js:74:16
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\find-visualstudio.js:70:14
gyp ERR! stack     at D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\find-visualstudio.js:372:16
gyp ERR! stack     at D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\util.js:54:7
gyp ERR! stack     at D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (node:child_process:404:5)
gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
gyp ERR! stack     at maybeClose (node:internal/child_process:1064:16)
gyp ERR! System Windows_NT 10.0.[203](https://github.com/jupyter-lsp/jupyterlab-lsp/runs/5439917867?check_suite_focus=true#step:17:203)48
gyp ERR! command "C:\\Miniconda3\\envs\\test\\node.exe" "D:\\a\\jupyterlab-lsp\\jupyterlab-lsp\\node_modules\\node-gyp\\bin\\node-gyp.js" "configure" "--fallback-to-build" "--module=D:\\a\\jupyterlab-lsp\\jupyterlab-lsp\\node_modules\\sqlite3\\lib\\binding\\node-v93-win32-x64\\node_sqlite3.node" "--module_name=node_sqlite3" "--module_path=D:\\a\\jupyterlab-lsp\\jupyterlab-lsp\\node_modules\\sqlite3\\lib\\binding\\node-v93-win32-x64" "--napi_version=8" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v93"
gyp ERR! cwd D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3
gyp ERR! node -v v16.13.2
gyp ERR! node-gyp -v v5.1.1
gyp ERR! not ok 
node-pre-gyp ERR! build error 
node-pre-gyp ERR! stack Error: Failed to execute 'C:\Miniconda3\envs\test\node.exe D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\bin\node-gyp.js configure --fallback-to-build --module=D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3\lib\binding\node-v93-win32-x64\node_sqlite3.node --module_name=node_sqlite3 --module_path=D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3\lib\binding\node-v93-win32-x64 --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v93' (1)
node-pre-gyp ERR! stack     at ChildProcess.<anonymous> (D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-pre-gyp\lib\util\compile.js:83:29)
node-pre-gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
node-pre-gyp ERR! stack     at maybeClose (node:internal/child_process:1064:16)
node-pre-gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
node-pre-gyp ERR! System Windows_NT 10.0.20348
node-pre-gyp ERR! command "C:\\Miniconda3\\envs\\test\\node.exe" "D:\\a\\jupyterlab-lsp\\jupyterlab-lsp\\node_modules\\node-pre-gyp\\bin\\node-pre-gyp" "install" "--fallback-to-build"
node-pre-gyp ERR! cwd D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3
node-pre-gyp ERR! node -v v16.13.2
node-pre-gyp ERR! node-pre-gyp -v v0.11.0
node-pre-gyp ERR! not ok 
Failed to execute 'C:\Miniconda3\envs\test\node.exe D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\node-gyp\bin\node-gyp.js configure --fallback-to-build --module=D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3\lib\binding\node-v93-win32-x64\node_sqlite3.node --module_name=node_sqlite3 --module_path=D:\a\jupyterlab-lsp\jupyterlab-lsp\node_modules\sqlite3\lib\binding\node-v93-win32-x64 --napi_version=8 --node_abi_napi=napi --napi_build_version=0 --node_napi_label=node-v93' (1)