Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release 2.9.0 broken on install #1345

Closed
krassowski opened this issue Oct 25, 2023 · 4 comments
Closed

Latest release 2.9.0 broken on install #1345

krassowski opened this issue Oct 25, 2023 · 4 comments
Labels

Comments

@krassowski
Copy link
Collaborator

It looks #1341 depends on a jupyter_client 8.5.0 but requirements have a much more relaxed 7.4.4 pin:

"jupyter_client>=7.4.4",

This leads to "Error Starting Kernel" in Jupyter applications:

Traceback (most recent call last):
  File "/lib/python3.9/site-packages/tornado/web.py", line 1786, in _execute
    result = await result
  File "/lib/python3.9/site-packages/jupyter_server/services/sessions/handlers.py", line 172, in patch
    await sm.update_session(session_id, **changes)
  File "/lib/python3.9/site-packages/jupyter_server/services/sessions/sessionmanager.py", line 469, in update_session
    self.kernel_manager.update_env(kernel_id=kernel_id, env=self.get_kernel_env(path, name))
  File "/lib/python3.9/site-packages/jupyter_client/multikernelmanager.py", line 226, in update_env
    self._kernels[kernel_id].update_env(env)
TypeError: update_env() takes 1 positional argument but 2 were given

We can either pass env conditionally or increase the required client version

CC @Carreau

@krassowski
Copy link
Collaborator Author

We already a number of users reporting this issue: jupyterlab/jupyterlab#15301
It looks that jupyter/jupyter_client#987 introduced the argument as required rather than default so some users see breakage due to updated client but not server, and some due to updated server but not client. Maybe both should be yanked for now?

@Carreau
Copy link
Contributor

Carreau commented Oct 25, 2023

This is weird. I'll check.

@Carreau
Copy link
Contributor

Carreau commented Oct 25, 2023

Oh, the parameter is kwarg only. It's a 3 char fix.

@Carreau
Copy link
Contributor

Carreau commented Oct 25, 2023

See jupyter/jupyter_client#989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants