Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MappingKernelManager.restart_kernel should pass through "now" keyword #402

Closed
vidartf opened this issue Feb 4, 2021 · 0 comments · Fixed by #404
Closed

MappingKernelManager.restart_kernel should pass through "now" keyword #402

vidartf opened this issue Feb 4, 2021 · 0 comments · Fixed by #404

Comments

@vidartf
Copy link
Member

vidartf commented Feb 4, 2021

The MultiKernelManager of jupyter client accepts a keyword now. As such, the same method on MappingKernelManager should probably accept generic keyword arguments and pass them through to the super method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update MappingKM.restart_kernel to accept now kwarg vidartf/jupyter_server
1 participant
@vidartf