Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make passwd and passwd_check compatible with jupyter notebook #448

Closed
CaselIT opened this issue Mar 18, 2021 · 5 comments
Closed

Make passwd and passwd_check compatible with jupyter notebook #448

CaselIT opened this issue Mar 18, 2021 · 5 comments

Comments

@CaselIT
Copy link

CaselIT commented Mar 18, 2021

Hi,

I'm trying to configure jupyterlab to use a password. I initially created the password with jupyter notebook password but it does not work with jupyterlab.
After some digging I think the problem is that while jupyter notebook updated the passwd and passwd_check to use a more secure algorithm in jupyter/notebook#3793, jupyter_server (and also ipython) did not.

Any reason not to update it here also?

Also a bit ot, how come there are 3 implementation of the same things that look identical?

@afshin
Copy link
Contributor

afshin commented Mar 18, 2021

Hi @CaselIT, we discussed this today at the server team meeting.  The history is that the ipython project split into several projects that included jupyter notebook.  They are now distinct products.  We should however allow jupyter notebook passwords to work with the jupyter server during a transition phase.  We agreed to detect a jupyter notebook password and use it if there is not one set on jupyter server, but warn the user.  As for jupyter/notebook#3793, we've added it to the Running list of Notebook PRs to port.

@CaselIT
Copy link
Author

CaselIT commented Mar 18, 2021

The history is that the ipython project split into several projects that included jupyter notebook. They are now distinct products.

from the outside I though it was actually all integrated, since I can use lab/notebook on the same server etc.

Thanks for the reply. Since it's already tracked in the other issue, we could close this if you prefer

@blink1073
Copy link
Contributor

We can leave this open to track "allow jupyter notebook passwords to work with the jupyter server"

@afshin
Copy link
Contributor

afshin commented Mar 19, 2021

cf #450 for the port.  Regarding the backwards compat, it is already handled when using nbclassic, which is installed when you install JupyterLab 3.0+.

@CaselIT
Copy link
Author

CaselIT commented Mar 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants