Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there a way for the extension to cleanup? #544

Closed
eastonsuo opened this issue Jun 19, 2021 · 1 comment
Closed

is there a way for the extension to cleanup? #544

eastonsuo opened this issue Jun 19, 2021 · 1 comment

Comments

@eastonsuo
Copy link
Contributor

eastonsuo commented Jun 19, 2021

as far as I can see it, when a KeyboardInterrupt accur, and jupyter server runs self._cleanup(), which is

def _cleanup(self):
        """General cleanup of files and kernels created
        by this instance ServerApp.
        """
        self.remove_server_info_file()
        self.remove_browser_open_files()
        self.cleanup_kernels()
        self.cleanup_terminals()

there is no way an extension can do some clean up

@eastonsuo eastonsuo changed the title is there a way to exit extension when a KeyboardInterrupt accur? is there a way to handler KeyboardInterrupt for an extension when a KeyboardInterrupt accur? Jun 19, 2021
@eastonsuo eastonsuo changed the title is there a way to handler KeyboardInterrupt for an extension when a KeyboardInterrupt accur? is there a way for the extension to cleanup? Jun 23, 2021
@Zsailer
Copy link
Member

Zsailer commented Aug 9, 2021

This should be solved by #526. Closing for now, but feel free to re-open if this PR doesn't address your needs.

@Zsailer Zsailer closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants