Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Session Storage #611

Closed
Zsailer opened this issue Nov 12, 2021 · 0 comments · Fixed by #614
Closed

Persistent Session Storage #611

Zsailer opened this issue Nov 12, 2021 · 0 comments · Fixed by #614

Comments

@Zsailer
Copy link
Member

Zsailer commented Nov 12, 2021

Problem

The default SessionManager stores the session data in an in-memory database.

If you'd like to make this session database persist beyond the lifetime of the jupyter server, you must subclass this method and override the connection property. I believe this should be a configurable trait on the session manager to avoid subclassing.

Also, none of the session manager methods that add changes to the session database call the .commit() method. As a consequence, even if the original database was written to disk, none of the changes would be written to disk.

Proposed Solution

  1. Make the session database connection path configurable
  2. Add .commit() to all methods that change the database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant