Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up license #1218

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Clean up license #1218

merged 3 commits into from
Feb 20, 2023

Conversation

dcsaba89
Copy link
Contributor

@blink1073, same change as the below PRs for jupyter-client for which now the package's license is perfectly recognized by github as well

jupyter/jupyter_client#934

please approve

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 79.27% // Head: 80.53% // Increases project coverage by +1.26% 🎉

Coverage data is based on head (dbaf431) compared to base (83f03e3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   79.27%   80.53%   +1.26%     
==========================================
  Files          68       68              
  Lines        8134     8134              
  Branches     1586     1586              
==========================================
+ Hits         6448     6551     +103     
+ Misses       1273     1169     -104     
- Partials      413      414       +1     
Impacted Files Coverage Δ
...ter_server/services/kernels/connection/channels.py 62.83% <0.00%> (-0.23%) ⬇️
jupyter_server/base/handlers.py 78.82% <0.00%> (+0.58%) ⬆️
jupyter_server/utils.py 85.46% <0.00%> (+5.81%) ⬆️
jupyter_server/serverapp.py 79.96% <0.00%> (+7.80%) ⬆️
jupyter_server/services/shutdown.py 100.00% <0.00%> (+23.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit ce8e7fc into jupyter-server:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants