Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

automated and cleaned build/imports #553

Merged
merged 1 commit into from
Mar 21, 2017
Merged

automated and cleaned build/imports #553

merged 1 commit into from
Mar 21, 2017

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Mar 21, 2017 •
edited
Loading

this makes sure that only needed functions are loaded for the package and no namespaces are attached when loading this one. the base package is always loaded, so no need to load or check for this one.

also it syncs the @export directives with the NAMESPACE

this superseeds #551

@poplav
Copy link
Contributor

poplav commented Mar 21, 2017

LGTM

@poplav poplav merged commit 0576c02 into jupyter:master Mar 21, 2017
@flying-sheep flying-sheep deleted the no-library branch March 21, 2017 19:16
@flying-sheep
Copy link
Contributor Author

nice, thanks!

you can use RStudio or devtools::document() to recreate Collate: and NAMESPACE now

@poplav
Copy link
Contributor

poplav commented Mar 21, 2017

Great, thanks @flying-sheep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flying-sheep @poplav