-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklinks CI too noisy #139
Comments
The failing check is visible on #137 |
You can ignore specific patterns. Probably better than removing it altogether. |
Idea: log broken links, rather than fail the check? |
check-links action belongs to Jupyter, should be doable to make it a configuration option whether to fail on broken links or just log them |
Some thoughts on getting to ✔️ on PRs, while still getting some robustness-over-time on the whole corpus:
To improve the overall value use |
closing this cause i turned off the ci a bit ago. if a better option comes a long then we should reopen. |
For reference I originally added the check links check on CI in #118 because it was not possible to find the meeting notes via the docs site. Maybe you could narrow done the scope of checked links to still check internal links, and ignore external links if these are not stable enough. |
thanks for the history! if someone spends time reworking the configuration then we should reference this issue in that work. |
Can we remove the checklinks ci or make it optional? We can't control link rot after 3 years
The text was updated successfully, but these errors were encountered: