Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklinks CI too noisy #139

Closed
gabalafou opened this issue Sep 7, 2023 · 8 comments
Closed

Checklinks CI too noisy #139

gabalafou opened this issue Sep 7, 2023 · 8 comments

Comments

@gabalafou
Copy link
Collaborator

Can we remove the checklinks ci or make it optional? We can't control link rot after 3 years

@gabalafou
Copy link
Collaborator Author

The failing check is visible on #137

@krassowski
Copy link
Member

You can ignore specific patterns. Probably better than removing it altogether.

@gabalafou
Copy link
Collaborator Author

Idea: log broken links, rather than fail the check?

@gabalafou
Copy link
Collaborator Author

check-links action belongs to Jupyter, should be doable to make it a configuration option whether to fail on broken links or just log them

@bollwyvl
Copy link
Contributor

bollwyvl commented Sep 7, 2023

Some thoughts on getting to ✔️ on PRs, while still getting some robustness-over-time on the whole corpus:

  • on a nightly job:
    • run the full check
    • show the check as a badge on e.g. the README so someone might see it
  • on a PR
    • one of
      • only check against changed files
      • check all files, but ignore_glob: "https?://" to only validate internal links

To improve the overall value use pytest-github-actions-annotate-failures so that the errors show up in the PR

@tonyfast
Copy link
Contributor

tonyfast commented Nov 9, 2023

closing this cause i turned off the ci a bit ago. if a better option comes a long then we should reopen.

@tonyfast tonyfast closed this as completed Nov 9, 2023
@jtpio
Copy link
Member

jtpio commented Nov 13, 2023

For reference I originally added the check links check on CI in #118 because it was not possible to find the meeting notes via the docs site.

Maybe you could narrow done the scope of checked links to still check internal links, and ignore external links if these are not stable enough.

@tonyfast
Copy link
Contributor

thanks for the history! if someone spends time reworking the configuration then we should reference this issue in that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants