Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Annotations #553

Closed
MSeal opened this issue Jun 13, 2020 · 0 comments · Fixed by #623
Closed

Type Annotations #553

MSeal opened this issue Jun 13, 2020 · 0 comments · Fixed by #623
Labels
enhancement new-user-friendly

Comments

@MSeal
Copy link
Contributor

MSeal commented Jun 13, 2020

Now there we're in Python 3 only, and given that we use classes in this repo as API contracts, I think it's time we look into adding type annotations to our code. This would help with clarifying the contract expectations and with avoiding subtle argument consumption changes causing inherited classes outside of the repo to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new-user-friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type annotations, refactor sync/async davidbrochart/jupyter_client
1 participant
@MSeal