Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force install jupyter_client master #675

Merged
merged 6 commits into from
Aug 16, 2021

Conversation

davidbrochart
Copy link
Member

No description provided.

@davidbrochart
Copy link
Member Author

As pointed out by @blink1073, we didn't test jupyter_client master but whatever version was installed by the downstream packages.
With this PR we do and we can see that:

@blink1073 blink1073 added this to the 7.0 milestone Aug 10, 2021
@blink1073
Copy link
Contributor

Kicking CI

@blink1073 blink1073 closed this Aug 13, 2021
@blink1073 blink1073 reopened this Aug 13, 2021
@davidbrochart
Copy link
Member Author

nbclient has not been released so we're not testing it with jupyter/nbclient#152.

@blink1073
Copy link
Contributor

We can kick this again after upcoming releases of ipykernel and nbclient on Monday.

@blink1073
Copy link
Contributor

blink1073 commented Aug 16, 2021

Looks like we're still failing one test in nbclient

@blink1073
Copy link
Contributor

blink1073 commented Aug 16, 2021

Builds are passing in nbclient itself

@davidbrochart
Copy link
Member Author

Looks like we also have all the downstream packages' dependencies pre-release installed, in particular ipywidgets==8.0.0a5 makes the nbclient test fail.

@davidbrochart
Copy link
Member Author

I think this is the normal behavior of the --pre option. Maybe then we should install master versions of downstream packages (without --pre).

@blink1073 blink1073 merged commit 31750bc into jupyter:master Aug 16, 2021
@blink1073
Copy link
Contributor

Thank you!

@davidbrochart davidbrochart deleted the fix_test_downstream branch August 16, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants