-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ipykernel dependency #255
Drop ipykernel dependency #255
Conversation
We should probably test against both |
yep, I was thinking to unit tests that execute cells, so need kernel. +1 to test on both |
73175c6
to
7f79672
Compare
We could do that, although xeus-python is already continuously tested with jupyter_kernel_test. |
Okay, let's test against whichever one is currently shipped with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We could work on testing a variety of language kernels at some point. |
Julia and R would be good for our namesake. 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - thanks.
Hmm. It just dawned on me. How will the default kernel name be determined? It currently comes from |
I think that it is fine to default to python3. Erroring when attempting to start a notebook when no kernel is available is expected. |
Understood. I'm just saying that previous to this change, there would not have been an error, so there's potential for users claiming a regression. Deployment manifests implicitly relying on that dependency (correctly or not) will need to be updated to include the installation of ipykernel now. That said, switching to jupyter_server is a good time to do this. |
Yes, that's why I did not open the PR to the notebook server. We are also removing some of these arbitrary dependencies in ipywidgets 8.0... |
…el-dependency Drop ipykernel dependency
Closes #254.