From 3371d7d8889987c788d94290c5f0ac61a4f91950 Mon Sep 17 00:00:00 2001 From: RRosio Date: Mon, 23 May 2022 23:20:42 -0700 Subject: [PATCH 1/3] updated import of IPython display module, import from core now deprecated --- nbclassic/tests/notebook/roundtrip.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nbclassic/tests/notebook/roundtrip.js b/nbclassic/tests/notebook/roundtrip.js index 82dfb314d..b88dae94e 100644 --- a/nbclassic/tests/notebook/roundtrip.js +++ b/nbclassic/tests/notebook/roundtrip.js @@ -207,7 +207,7 @@ casper.notebook_test(function () { this.then(function() { clear_and_execute(this, - "from IPython.core.display import SVG; SVG(" + svg + ")"); + "from IPython.display import SVG; SVG(" + svg + ")"); }); this.then(function ( ) { @@ -216,7 +216,7 @@ casper.notebook_test(function () { this.then(function() { clear_and_execute(this, - "from IPython.core.display import SVG, display; display(SVG(" + svg + "))"); + "from IPython.display import SVG, display; display(SVG(" + svg + "))"); }); this.then(function ( ) { From b0233a5bd26f0fab1cc72a0e7ac9b1b4856c4afb Mon Sep 17 00:00:00 2001 From: RRosio Date: Mon, 23 May 2022 23:23:48 -0700 Subject: [PATCH 2/3] importing __version__ into init file to make it available for base/misc test --- nbclassic/__init__.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/nbclassic/__init__.py b/nbclassic/__init__.py index 107fa47c3..fa07df0e0 100644 --- a/nbclassic/__init__.py +++ b/nbclassic/__init__.py @@ -1,4 +1,6 @@ import os +from ._version import __version__ + # Packagers: modify this line if you store the notebook static files elsewhere DEFAULT_STATIC_FILES_PATH = os.path.join(os.path.dirname(__file__), "static") From f6a14a43de7a60defe6aab041f8bceeb40133796 Mon Sep 17 00:00:00 2001 From: RRosio Date: Mon, 23 May 2022 23:57:30 -0700 Subject: [PATCH 3/3] update module name from notebook to nbclassic for base test --- nbclassic/tests/base/misc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbclassic/tests/base/misc.js b/nbclassic/tests/base/misc.js index 3af58f86f..373969877 100644 --- a/nbclassic/tests/base/misc.js +++ b/nbclassic/tests/base/misc.js @@ -5,7 +5,7 @@ casper.notebook_test(function () { var jsver = this.evaluate(function () { var cell = IPython.notebook.get_cell(0); - cell.set_text('import notebook; print(notebook.__version__)'); + cell.set_text('import nbclassic; print(nbclassic.__version__)'); cell.execute(); return IPython.version; });