Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when session killed from other tab, notebook UI doesn't reflect change #3178

Closed
ashsny opened this issue Jan 3, 2018 · 1 comment
Closed
Milestone

Comments

@ashsny
Copy link

ashsny commented Jan 3, 2018

Repro steps:

  1. Open notebook in tab 1.
  2. In another tab, visit the "Open" page, navigate to the "Running" tab.
  3. Observe currently running notebook process under "Notebooks" and click "Shutdown" button.

Expected: Kernel status in tab 1 shows "Kernel is not running", "No kernel" notification appears.
Actual: Kernel status in tab 1 shows "Kernel idle", no notifications. If a cell is run, it just stays pending forever.

Under the hood, if a cell is running in tab 1 when the kernel is interrupted, there is no "shutdown_reply" message on iopub. If a cell is not running in tab 1, there is a "shutdown_reply" but it is (apparently) ignored.

@jtpio
Copy link
Member

jtpio commented Jun 21, 2023

Checking with the latest Notebook 7.0.0rc0, it seems like this is now working as expected:

kernel-shut-down-tabs.mp4

Closing as fixed, but feel free to re-open if you still want to discuss it or open a new issue if you have more questions. Thanks!

@jtpio jtpio closed this as completed Jun 21, 2023
@jtpio jtpio added this to the 7.0 milestone Jun 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants