Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable / check the Notifications feature for Notebook 7 #6867

Closed
jtpio opened this issue May 11, 2023 · 1 comment · Fixed by #6900
Closed

Enable / check the Notifications feature for Notebook 7 #6867

jtpio opened this issue May 11, 2023 · 1 comment · Fixed by #6900
Labels
enhancement
Milestone
7.1.0

Comments

@jtpio
Copy link
Member

jtpio commented May 11, 2023

JupyterLab 4 adds support for displaying notifications.

We should check whether they work in Notebook 7. Or could be leveraged by third-party extensions.
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label May 11, 2023
@jtpio jtpio added this to the 7.0 milestone May 11, 2023
@jtpio jtpio added enhancement and removed status:Needs Triage Applied to issues that need triage labels May 11, 2023
@jtpio
Copy link
Member Author

jtpio commented May 23, 2023

Ah looks like the upstream plugin has a hard dependency on IStatusBar at the moment: https://github.com/jtpio/jupyterlab/blob/eeaa6505f658f7eaaad18ea2d7f15c3c5da0b23a/packages/apputils-extension/src/notificationplugin.tsx#L373

@jtpio jtpio modified the milestones: 7.0, 7.1 May 23, 2023
@jtpio jtpio mentioned this issue May 25, 2023
Merged
@jtpio jtpio mentioned this issue Jun 5, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Add the notification plugin jtpio/notebook
1 participant
@jtpio