Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default notebook windowing mode #7318

Closed
jtpio opened this issue Apr 10, 2024 · 1 comment · Fixed by #7321
Closed

Fix the default notebook windowing mode #7318

jtpio opened this issue Apr 10, 2024 · 1 comment · Fixed by #7321
Labels
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Apr 10, 2024

#7312 added a plugin to default to the defer windowing mode, because the full windowing mode still has CSS issues:

We should look into removing it. Or find a way to use defer but for Notebook 7 only, without setting the new value in the settings.

In #7312 (comment) @krassowski suggests:

It looks like you would need to override the notebookConfig in factory: https://github.com/jupyterlab/jupyterlab/blob/6152e3a5f94d728ccd2727d6d8413f12ddafb669/packages/notebook-extension/src/index.ts#L1867-L1898

An alternative would be to use setting transforms to change the default value temporarily.

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to issues that need triage label Apr 10, 2024
@jtpio jtpio added this to the 7.2.0 milestone Apr 10, 2024
@RRosio RRosio added bug and removed status:Needs Triage Applied to issues that need triage labels Apr 16, 2024
@jtpio
Copy link
Member Author

jtpio commented Apr 17, 2024

Seeing this behavior when trying in a fresh environment on Binder, from https://gist.github.com/jtpio/befb8ebf2b630b4748e2538f79877022:

notebook-default-defer.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants