add LegacyBinderDockerfile buildpack #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use stdout.write otherwise
- stages files, which previous binder did automatically and repo2docker does not - installs required versions of ipykernel, jupyterhub, notebook - registers kernelspecs explicitly - launches notebook server with python3 env - removes nb_conda_kernels, which was causing trouble - sets JUPYTER_PATH so kernelspecs and extensions that were being installed into the python 2 env will still be picked up
yuvipanda
reviewed
May 25, 2017
repo2docker/detectors.py
Outdated
| else: | ||
| sys.stdout.write(progress['stream']) | ||
|
|
||
| _legacy_binder_docker_appendix = """ |
There was a problem hiding this comment.
can you move this to be a traitlet under the Legacy Builder? keeps it contained and out of the global namespace of the file, + possibly allows overrides if needed...
…appendix and make it overrideable
minrk
force-pushed
the
old-binder-dockerfile
branch
from
d2b6dce to
82ccb38
Compare
shota-matsumoto-lm
referenced
this pull request
in lifematics/CS-repo2docker
Feb 1, 2024
Show human readable value for mem and cpu limits
yacchin1205
pushed a commit
to yacchin1205/repo2docker
that referenced
this pull request
Apr 4, 2024
[GRDM-42299] Upstreamの取り込み (2024.03.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only run on dockerfiles with
FROM andrewosh/binder-base