conda: separate base envs by Python version #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will allow us to create different base envs based on Python major.minor versions
if env specifies a version of Python other than the default, a different base env will be selected. This should fix some issues where switching Python versions on the base env with a bunch of packages installed can fail, and will always produce a huge amount of churn. Future change: - place py2 in a separate env, like we do for requirements.txt
|
Thanks @minrk! |
yuvipanda
added a commit
to yuvipanda/mybinder.org-deploy
that referenced
this pull request
Jan 3, 2018
jupyterhub/repo2docker#182, jupyterhub/repo2docker#181 and jupyterhub/repo2docker#183 are the major changes. The image is bigger now, since it's no longer based on alpine.
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
conda: separate base envs by Python version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downgrading the root env from Python 3.6 to 2.7 (or even 3.5 in some cases) is always very expensive and can fail due to the complicated transaction.
This fixes issues where builds fail when Python 2 is requested.
What I'd like to do eventually, and we will *need* to do once certain packages start dropping py2 support, is to handle Python 2 differently by putting it in a different env, like we do for pip. But for now, it's simpler to handle Python 2 the same as Python 3.Python 2 is handled specially by putting it in a different env, just like with requirements.txt.
closes #28