Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add explicit log message on failing Docker connection #779

Merged
merged 2 commits into from
Sep 7, 2019
Merged

add explicit log message on failing Docker connection #779

merged 2 commits into from
Sep 7, 2019

Conversation

nuest
Copy link
Contributor

@nuest nuest commented Sep 7, 2019 •
edited by minrk
Loading

closes #774

@willingc willingc requested review from betatim and minrk September 7, 2019 09:02
@minrk
Copy link
Member

minrk commented Sep 7, 2019 

            try:
                docker_client = docker.APIClient(version="auto", **kwargs_from_env())
            except DockerException as e:
                self.log.error("\nError connecting: %s. Helpful hints..\n", e)
                self.exit(1)

@nuest nuest force-pushed the docker_daemon_logmessage branch from f0aab04 to b3f82db Compare September 7, 2019 10:16
@betatim betatim changed the title add explicit log message on failing Docker connection, see #774 add explicit log message on failing Docker connection Sep 7, 2019
@minrk minrk merged commit 8ef5faa into jupyterhub:master Sep 7, 2019
@henchbot henchbot mentioned this pull request Sep 8, 2019
Merged
@choldgraf choldgraf added user-support Questions on using repo2docker maintenance Under the hood fixes and improvements and removed user-support Questions on using repo2docker labels Oct 8, 2019
markmo pushed a commit to markmo/repo2docker that referenced this pull request Jan 22, 2021
@minrk
Merge pull request jupyterhub#779 from nuest/docker_daemon_logmessage
a7b94aa 
add explicit log message on failing Docker connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim Awaiting requested review from betatim

@minrk minrk Awaiting requested review from minrk

Assignees
No one assigned
Labels
maintenance Under the hood fixes and improvements workflow:needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

During startup check that docker is running
4 participants
@nuest @minrk @choldgraf @willingc