use getpass.getuser instead of os.getlogin #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.getlogin doesn't work everywhere (can raise OSError, inappropriate ioctl for device)
|
We need to add a step to the azure pipeline that sets up Git credentials as the tests that are now failing are around creating temporary commits. |
choldgraf
added
user-support
markmo
pushed a commit
to markmo/repo2docker
that referenced
this pull request
Jan 22, 2021
use getpass.getuser instead of os.getlogin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.getlogin apparently doesn't work everywhere (can raise OSError, inappropriate ioctl for device)
and is failing on azure pipelines tests