Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding binder folder text #56

Merged
merged 2 commits into from
Dec 29, 2017
Merged

adding binder folder text #56

merged 2 commits into from
Dec 29, 2017

Conversation

choldgraf
Copy link
Member

This adds more language explaining the usage of the binder/ folder, as a number of people keep asking questions about whether this is possible. (e.g. jupyterhub/binderhub#381)

cc @betatim

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes for clarity. Great addition @choldgraf.

doc/using.rst Outdated
@@ -20,6 +20,10 @@ your Binder repository should contain at least:
* One (or many) text files that specify the requirements of your code.
For a complete list, see :ref:`config-files`.

Configuration text files should be either in the **root** of your
repository, or in a folder in the root of the repository that is called
``binder``. E.g., ``myrepo/binder/requirements.txt``.
Copy link
Contributor

@willingc willingc Dec 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's indent this to be part of the bullet in line 20.

  • Configuration files (one or more text files) that specify the requirements of building your project's code.
    For a complete list of supported files, see :ref:config-files. Configuration files may be placed in the
    root of your repository or in a binder folder in the repository's root (i.e. myproject/binder/).
    If a binder folder is used, Binder will only read configuration files from that location and will ignore
    those in the repository's root.

doc/faq.rst Outdated
├── myfile.py
└── requirements.txt

In this case, only the ``requirments.txt`` file inside ``binder/`` will be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration files may be placed in the root of your repository or in a binder folder in the repository's root (i.e. myproject/binder/). If a binder/ folder is used, Binder will only read configuration files from that location (i.e. myproject/binder/requirements.txt and will ignore those in the repository's root (myproject/environment.yml and myproject/requirements.txt).

@choldgraf
Copy link
Member Author

choldgraf commented Dec 28, 2017

thx for the comments @willingc , changes made!

@betatim betatim merged commit c061b52 into jupyterhub:master Dec 29, 2017
@betatim
Copy link
Member

betatim commented Dec 29, 2017

Bimbambosh! Thanks for making the effort of writing it down 📝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants