-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom resource requests #759
Comments
As an aside I've seen more requests for item 2 than item 1 though both are important. |
Thanks for opening this issue, @jhamman. I think we should do (2), since resources are a runtime parameter (rather than a build time one). We can probably suggest / populate defaults from the repo at some point, but that's probably a separate issue. |
I think making resource requests runtime parameters (I think this is what you call option 2) is a good place to start. It lets the creator of the repository set a "default" via the link they give out/place in their badge. Specifying it inside the repository is a bit tricky because it means BinderHub would have to clone a repository to look inside it to find the file that might specify resource requests. (This has been discussed a few times before and so far the consensus is that we don't want to start looking inside repositories) There is also #712 about naming of URL parameters, including ones that not all BinderHubs support. |
Thanks all. I think we should focus this conversation on #712 for now. I'll revive that conversation and we can go from there. |
In the monthly Binderhub/Jupyterhub call today, I brought up the concept of custom resource requests in the binderhub framework. A few use cases came up and we briefly discussed at least two approaches for addressing this topic.
Use-cases
Approaches
Two high-level approaches have been discussed:
./binder
directory. This config would be passed on to the kubernetes request for the user pod. For example:https://mybinder.org/v2/gh/dask/dask-examples/master?urlpath=lab
where the?urlpath=lab
is some special request. You could imaging a API and UI that basically extend this to include other things:https://mybinder.org/v2/gh/dask/dask-examples/master?urlpath=lab&cpu=8&memory=26G&GPU=8
The main distinction between these two points is that one lives in the repo, whilst the olther is configured by the user of a binder at a specific time.
cc @minrk @choldgraf @betatim @jzf2101 @yuvipanda @craig-willis
The text was updated successfully, but these errors were encountered: