From eeb1d4f3df5ae3d7c4b7ceec8e778550d6dcd746 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Sat, 25 Jan 2025 00:42:11 +0000 Subject: [PATCH 1/4] Test Pytohn 3.8 --- .github/workflows/test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 49d1a9241..55a62a182 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -411,7 +411,8 @@ jobs: - uses: actions/setup-python@v5 id: setup-python with: - python-version: "3.12" + # Set this to the oldest Python version supported by BinderHub + python-version: "3.8" - name: Cache pip uses: actions/cache@v4 From 51568c11ea6927b7b20f2c1f5e732a8907178a59 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Sat, 25 Jan 2025 00:44:34 +0000 Subject: [PATCH 2/4] Test Python 3.9 BinderHub is broken on Python 3.8: ``` Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/home/runner/work/binderhub/binderhub/binderhub/__main__.py", line 2, in from binderhub.app import main File "/home/runner/work/binderhub/binderhub/binderhub/app.py", line 45, in from .base import VersionHandler File "/home/runner/work/binderhub/binderhub/binderhub/base.py", line 13, in from .utils import ip_in_networks File "/home/runner/work/binderhub/binderhub/binderhub/utils.py", line 172, in ip_addr: str, networks: Iterable[ipaddress.IPv4Network | ipaddress.IPv6Network] ``` --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 55a62a182..614cc5d2d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -412,7 +412,7 @@ jobs: id: setup-python with: # Set this to the oldest Python version supported by BinderHub - python-version: "3.8" + python-version: "3.9" - name: Cache pip uses: actions/cache@v4 From 55742ea53c5452ed71fa34852111bce98a7a0471 Mon Sep 17 00:00:00 2001 From: Simon Li Date: Sat, 25 Jan 2025 00:47:57 +0000 Subject: [PATCH 3/4] Test Python 3.10 BinderHub is broken on Python 3.9: ``` Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/runpy.py", line 197, in _run_module_as_main return _run_code(code, main_globals, None, File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/runpy.py", line 87, in _run_code exec(code, run_globals) File "/home/runner/work/binderhub/binderhub/binderhub/__main__.py", line 2, in from binderhub.app import main File "/home/runner/work/binderhub/binderhub/binderhub/app.py", line 45, in from .base import VersionHandler File "/home/runner/work/binderhub/binderhub/binderhub/base.py", line 13, in from .utils import ip_in_networks File "/home/runner/work/binderhub/binderhub/binderhub/utils.py", line 172, in ip_addr: str, networks: Iterable[ipaddress.IPv4Network | ipaddress.IPv6Network] ``` --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 614cc5d2d..e4ea4c5a3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -412,7 +412,7 @@ jobs: id: setup-python with: # Set this to the oldest Python version supported by BinderHub - python-version: "3.9" + python-version: "3.10" - name: Cache pip uses: actions/cache@v4 From ec9c3c4f6809bafeffaa4fcb9ece20520fcffb7e Mon Sep 17 00:00:00 2001 From: Simon Li Date: Sat, 25 Jan 2025 00:53:10 +0000 Subject: [PATCH 4/4] python_requires >= 3.10 --- pyproject.toml | 2 +- setup.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index dd14d04e3..79fd2470c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -11,7 +11,7 @@ build-backend = "setuptools.build_meta" [tool.black] # target-version should be all supported versions, see # https://github.com/psf/black/issues/751#issuecomment-473066811 -target-version = ["py38", "py39", "py310", "py311"] +target-version = ["py310", "py311", "py312"] # The default isort output conflicts with black autoformatting. diff --git a/setup.py b/setup.py index c2e614450..65aeb2027 100644 --- a/setup.py +++ b/setup.py @@ -42,7 +42,7 @@ name="binderhub", version=versioneer.get_version(), cmdclass=versioneer.get_cmdclass(cmdclass), - python_requires=">=3.8", + python_requires=">=3.10", author="Project Jupyter Contributors", author_email="jupyter@googlegroups.com", license="BSD",