Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Authorization to Route #90

Open
quasiben opened this issue Nov 21, 2016 · 5 comments
Open

Token Authorization to Route #90

quasiben opened this issue Nov 21, 2016 · 5 comments

Comments

@quasiben
Copy link
Contributor

quasiben commented Nov 21, 2016

I'm interested in using a proxy with a token auth scheme. Is it out of scope for configurable-http-proxy to check a token/jwt before routing ?

@minrk
Copy link
Member

minrk commented Nov 22, 2016

I think it might be. How would you handle that? A single app-wide token? Or per-route tokens? Checking cookies vs headers, etc.?

It's a bit of a can of worms to start implementing auth in the proxy, since there are so many different ways to do it.

@minrk
Copy link
Member

minrk commented Nov 23, 2016

Or were you thinking of token-based routing (i.e. specifying the target based on token)? That's an interesting idea. I'm not sure quite how it would fit.

@quasiben
Copy link
Contributor Author

Sorry, i took off for a bit. I was thinking about single app-wide tokens. Token generation should be handled by some other auth and be responsible for correctly generating the token/permissioning to a specific route. In this case, configurable-http-proxy simply checks if the JWT is valid or not

@arnaudRenardRomeo
Copy link

I'm also interested with this enhancement.

It could be based on a simple cookie, and I can provide to the API, a list of cookies (name/values) allowed to access to the path.
Other solution is to implement Oauth or any other solution, but it's much more complex

@oschuett
Copy link

oschuett commented Jan 18, 2019

I also think this would be a great feature. It could be implemented like --host-routing. The advantage of cookie based routing would be that all users get the same urls, which would allow sharing them. Right now e.g. it's not possible to readily share mybinder urls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants