Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass URL filename and URL parameters to browser #222

Closed
jhgoebbert opened this issue Nov 8, 2020 · 2 comments · May be fixed by #267
Closed

Pass URL filename and URL parameters to browser #222

jhgoebbert opened this issue Nov 8, 2020 · 2 comments · May be fixed by #267

Comments

@jhgoebbert
Copy link

jhgoebbert commented Nov 8, 2020

Some webservices can be initialized directly by passing parameters in the URL - for example this is the case for Xpra:
http://localhost:10000/index.html?username=test&password=123456

If one wants to use jupyter-server-proxy to start a xpra html5 desktop one would first start xpra on the server, generate a one-time-password and might think it would be fine to add this password using a mappath command as the password uri parameters to /index.html

But this is will not work (!),
because the index.html of Xpra wants to reads the password through the url parameters with javascript on the client side, too.

Proposed change

Url parameters should be passed to the browser.

Alternative options

The url parameters are shown to the user and he has to add it manually to the URL in the browsers address line.

Who would use this feature?

Any webservice, which extracts information from the url parameter (using JavaScript) on client side.

@jhgoebbert
Copy link
Author

jhgoebbert commented Nov 9, 2020

To be more concrete, I have written an Xpra proxy for jupyter-server proxy:
https://github.com/FZJ-JSC/jupyter-xprahtml5-proxy

Here I would like to use password/encryption of Xpra through the URI parameters, which is not possible at the moment.

@jhgoebbert jhgoebbert changed the title Pass uri parameters added in mappath to browser Pass URL filename and URL parameters to browser Nov 19, 2020
@jhgoebbert
Copy link
Author

The following pull request adds this feature to jupyter-server-proxy: #226

How it is used can be seen here:
https://github.com/FZJ-JSC/jupyter-xprahtml5-proxy/blob/v0.3.0_devel/jupyter_xprahtml5_proxy/__init__.py#L125

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant