Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter in the file browser when refreshed #20

Closed
krassowski opened this issue Nov 8, 2023 · 1 comment · Fixed by #21
Closed

Jitter in the file browser when refreshed #20

krassowski opened this issue Nov 8, 2023 · 1 comment · Fixed by #21
Labels
bug Something isn't working

Comments

@krassowski
Copy link
Contributor

Description

I am noticing a jitter in the file browser on refreshing it. Please see the attached gif.
jitter2

Reproduce

Click on the refresh button in the filebrowser.
This is more easily reproducible when there is a large number of items in a directory.

Context

I'm using - jupyterlab==4.0.6

Originally posted by @divyansshhh in jupyterlab/jupyterlab#15365

@krassowski
Copy link
Contributor Author

krassowski commented Nov 8, 2023

This looks related to how the favourite icon in breadcrumbs is rendered with a delay; while a simple fix would be to apply some constant height it might not work with themes, and ideally when breadcrumbs do not change the widget should not be re-rendered at all. Maybe this something that will need addressing in JupyterLab too, but then even when breadcrumbs change the the folder was renamed the icon ideally would not need to be re-rendered.

Maybe the signal is to eagerly emitted?

return (
<UseSignal
signal={props.manager.favoritesChanged}
initialSender={props.manager}
>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant