-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add this package to conda-forge #58
Comments
Adding a package to conda-forge is often as simple as running Grayskull to generate a PR in staged-recipes. Anyone is welcome to clone my branch and fix things up to get this published on conda-forge. A few initial observations:
+ python .ci_support/build_all.py
Traceback (most recent call last):
File "/Users/runner/work/1/s/.ci_support/build_all.py", line 213, in <module>
check_recipes_in_correct_dir(root_dir, "recipes")
File "/Users/runner/work/1/s/.ci_support/build_all.py", line 185, in check_recipes_in_correct_dir
raise RuntimeError(f"recipe {path.parts} in wrong directory")
RuntimeError: recipe ('jupyterlab-spreadsheet-editor', 'meta.yaml') in wrong directory So this may unfortunately take some effort to get running, but I don't have the time to work further on this. |
@maresb thanks for starting the work! Of course publishing it on conda-forge is very welcome! As for vendoring icons this should not be a problem. It appears that you need to move the file into Also, you may want to reuse parts of other recipes from jupyterlab-contrib, e.g. https://github.com/conda-forge/jupyterlab-spellchecker-feedstock/blob/main/recipe/meta.yaml Please also add me as a maintainer :) |
Thanks @krassowski for the feedback! I did it in a big rush, so I'm not surprised there were mistakes. I did another very quick pass to address your points. @drhagen, could you please comment on that PR (conda-forge/staged-recipes#22209) if you're willing to be maintainer? |
Is your feature request related to a problem? Please describe.
Would it be possible to add this package to conda-forge?
conda-lock
cannot lock this package because it is not in conda-forge but still depends onjupyterlab
, which is in conda-forge. See this question on StackOverflow showing this particular failure. When these kinds of problems occur, the maintainers of conda-forge recommend this solution.Describe the solution you'd like
The latest version of this package is contributed to conda-forge.
Describe alternatives you've considered
There are some workarounds, all with drawbacks:
conda install
will install different packages over timeAdditional context
0.6.1
0.6.1
Ubuntu 20.04
The text was updated successfully, but these errors were encountered: