Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration with jupyter-git extension #24

Open
ebw44 opened this issue Oct 21, 2021 · 3 comments
Open

Improve integration with jupyter-git extension #24

ebw44 opened this issue Oct 21, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@ebw44
Copy link

ebw44 commented Oct 21, 2021

jupyterlab 3.2.1
jupyterlab-git 0.33.0
jupyterlab-server 1.2.0
jupyterlab-unfold 0.1.6

It seems that this great extension is not fully compatible with another great extension jupyter-git.
jupyter-git requires the user to select an "active folder" in the FileBrowser that is a git repository. But jupyterlab-unfold doesn't allow to change the "active folder".
One solution is to start jupyter lab in a git repository but it prevent browsing files outside of that repository.
It would be great if the "active folder" could be changed by a double-click or a right click.

@ebw44 ebw44 added the bug Something isn't working label Oct 21, 2021
@ebw44
Copy link
Author

ebw44 commented Oct 21, 2021

I'm not sure how to remove the "bug" label from this issue, but it is definitively not a bug.
Also there is a mention of that problem in jupyter-git. So feel free to close this one if you believe the way to go is the PR in jupyter-git

@fcollonval fcollonval added enhancement New feature or request and removed bug Something isn't working labels Dec 10, 2021
@sntgluca
Copy link

sntgluca commented Jun 2, 2022

Hi all,

I just came across this extension, which I consider a really good idea.
It was a cold shower noticing the issue with jupyter-git...

I might be wrong, but I am not sure if the problem is in jupyter-git.
Personally, I would expect the "base path" to be the most downstream directory selected by the user.

What do you say? Is there any suggestion from your side to get past the problem?
Thanks!

@fcollonval
Copy link
Member

Thanks both for reaching out. I think the best path forward is to allow the jupyterlab git extension to handle is own active folder. If you want to contribute, I can help you rebooting that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants