Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/learn can run with no parameters #819

Closed
JasonWeill opened this issue Jun 5, 2024 · 2 comments · Fixed by #1012
Closed

/learn can run with no parameters #819

JasonWeill opened this issue Jun 5, 2024 · 2 comments · Fixed by #1012
Labels
bug Something isn't working @jupyter-ai/chatui

Comments

@JasonWeill
Copy link
Collaborator

Description

In the chat UI, /learn can be run with no parameters. In this case, I think it tries to run the command on the current directory.

Expected behavior

Running /learn with no parameters should produce an error with usage information.

Context

See also #633, with some other quirks when running the /learn command.

Found while testing #810 by @dlqqq , but not necessarily introduced by this PR.

@JasonWeill JasonWeill added bug Something isn't working @jupyter-ai/chatui labels Jun 5, 2024
@andrewfulton9
Copy link
Contributor

/learn is currently learning on the root (or preferred directory) if no parameter is given. Another option would be to add a dialog warning to require a confirmation on what /learn will be learning on if a parameter isn't given. That would make it clear what will be done and give the user the opportunity to cancel the task if learning on all files under the root directory wasn't intended.

@JasonWeill
Copy link
Collaborator Author

#965 is a request for a "cancel" option, which should work for both messages and commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @jupyter-ai/chatui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants