Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final v3.0.0 release #354

Closed
davidbrochart opened this issue Sep 17, 2024 · 31 comments
Closed

Final v3.0.0 release #354

davidbrochart opened this issue Sep 17, 2024 · 31 comments
Labels
question Further information is requested

Comments

@davidbrochart
Copy link
Collaborator

It seems to me that we could release jupyter-collaboration v3.0.0. I installed v3.0.0b3 and it works fine with JupyterLab v4.2.5. Or should we make another pre-release that includes the timeline?

@davidbrochart davidbrochart added the question Further information is requested label Sep 17, 2024
@davidbrochart
Copy link
Collaborator Author

What do you think about including #353?

@jtpio
Copy link
Member

jtpio commented Sep 17, 2024

Or should we make another pre-release that includes the timeline?

Is the timeline opt-in? Or can it be collapsed? Thinking it might take quite some space in the status bar, according to the screencast in the blog post: https://blog.jupyter.org/exploring-a-documents-timeline-in-jupyterlab-6084f96db263

If so, it could be useful to mention it in the docs: https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/

@davidbrochart
Copy link
Collaborator Author

Is the timeline opt-in?

It's not opt-in, but if you don't use it then no slider is shown, only this icon:
image

@krassowski
Copy link
Member

I think we should sync it with JupyterLab 4.3.0 final. I think we do not have to wait for #345 but it would be lovely to include it if we can.

@davidbrochart
Copy link
Collaborator Author

I think we should sync it with JupyterLab 4.3.0 final.

When do you see this happening?

@krassowski
Copy link
Member

One week after RC gets published assuming no new blockers

@davidbrochart
Copy link
Collaborator Author

I just released jupyter-collaboration v3.0.0b4.

@davidbrochart
Copy link
Collaborator Author

I think we should sync it with JupyterLab 4.3.0 final.

But why does it need to be synced, since it works with JupyterLab 4.2.5?

@krassowski
Copy link
Member

Ah, the dependency is the other way round. JupyterLab 4.3 requires the new collaboration packages to have lifted ydoc version pin, right? In that case I guess it does not need to wait :)

@davidbrochart
Copy link
Collaborator Author

davidbrochart commented Sep 18, 2024

JupyterLab 4.3 requires the new collaboration packages to have lifted ydoc version pin, right?

Yes. I just tried jupyter-collaboration v3.0.0b4 with JupyterCAD, everything seems to work fine.
I'd like to have #353 in before the final release, it will allow to swap jupyter-collaboration with jupyter-shared-drive (or any other collaboration system that implements the ICollaborativeDrive), and have support for JupyterLite.

@krassowski
Copy link
Member

So we are good to release final, right?

@davidbrochart
Copy link
Collaborator Author

There is still #353 that would be good to get in before v3. If it's merged after v3 that would be another breaking change. I'll rebase it.

@davidbrochart
Copy link
Collaborator Author

I just release v3.0.0beta8 which has #353, everything seems to work fine.
I guess we are good to release v3.0.0 final?

@davidbrochart
Copy link
Collaborator Author

One thing I noticed is that when creating a new notebook, no empty cell is created, even though jupyterlab/jupyterlab#16732 was not merged yet. It might be because of jupyter-server/jupyter_ydoc#266, but I thought this was not enough and the frontend added an empty cell if there was no cell.

@davidbrochart
Copy link
Collaborator Author

I confirm it's caused by jupyter-server/jupyter_ydoc#266.

@davidbrochart
Copy link
Collaborator Author

I think we should merge jupyterlab/jupyterlab#16732 and have jupyter-server/jupyter_ydoc#266 enabled when allowEmptyNotebook is true.

@davidbrochart
Copy link
Collaborator Author

I'm planning to release v3 soon, if there are no objections.

@davidbrochart
Copy link
Collaborator Author

I reverted jupyter-server/jupyter_ydoc#266 in jupyter-server/jupyter_ydoc#280.
I don't see any blocker to release jupyter-collaboration v3.0.0 final. I'll do it today or tomorrow, please let me know if you have any objection.

@davidbrochart
Copy link
Collaborator Author

Hmm prep_release failed. Could it be due to #343 @brichet?

@jtpio
Copy link
Member

jtpio commented Oct 18, 2024

@davidbrochart
Copy link
Collaborator Author

Oh I was not aware of this, I just specified 3.0.0 and thought it would work.
It seems I could use release but it means we need to make an rc before?

@jtpio
Copy link
Member

jtpio commented Oct 18, 2024

yeah it's also a good practice to make an rc first.

@jtpio
Copy link
Member

jtpio commented Oct 18, 2024

But then it can be weird to do the final release right after. Maybe do it on Monday to give the rc a few days? (or at least the weekend).

When you do the final release, check this box so the changelog is correctly populated:

image

@davidbrochart
Copy link
Collaborator Author

OK, let's release v3.0.0 final next week. I just released v3.0.0rc0.

@davidbrochart
Copy link
Collaborator Author

Since #379 seems to target v3.1.0, should we release v3.0.0 now?

@jtpio
Copy link
Member

jtpio commented Oct 22, 2024

Similar to this JupyterLab 4.3.0 (blocker) issue: jupyterlab/jupyterlab#16649

Are we fine to depend on an alpha release of @jupyter/ydoc?

"@jupyter/ydoc": "^2.0.0 || ^3.0.0-a3",

@davidbrochart
Copy link
Collaborator Author

We could release @jupyter/ydoc v3.0.0 before, and update the dependency here?

@jtpio
Copy link
Member

jtpio commented Oct 22, 2024

Yes, but from the discussion in jupyter-server/jupyter_ydoc#281, there seems to be one more issue to be fixed in jupyter_ydoc first before: jupyter-server/jupyter_ydoc#269

@davidbrochart
Copy link
Collaborator Author

Ah yes I forgot.

@davidbrochart
Copy link
Collaborator Author

I just bumped jupyter-ydoc v3.0.0, and I am going to release jupyter-collaboration v3.0.0 final.

@davidbrochart
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants