Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode module is deprecated #374

Open
JasonWeill opened this issue Oct 15, 2024 · 2 comments
Open

punycode module is deprecated #374

JasonWeill opened this issue Oct 15, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@JasonWeill
Copy link
Contributor

When I run jlpm build with code at the tip of main, I see a warning:

(node:80138) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
lerna notice cli v6.6.2

    ✔  @jupyter/collaboration:build (1s)
    ✔  @jupyter/collaborative-drive:build (1s)
    ✔  @jupyter/docprovider:build (987ms)
    ✔  @jupyter/docprovider-extension:build (8s)
    ✔  @jupyter/collaboration-extension:build (8s)

This appears to be related to the punycode module bundled with Node, which has been deprecated since Node 7, in 2016. There is a third-party package of the same name that was most recently updated in October 2023: https://www.npmjs.com/package/punycode .

Remove all uses of punycode that are deprecated, and use the third-party package instead.

@JasonWeill JasonWeill added the bug Something isn't working label Oct 15, 2024
@jtpio
Copy link
Member

jtpio commented Oct 21, 2024

Thanks @JasonWeill for the report.

I think this also happens on a dev install of JupyterLab, so not sure it's directly related to jupyter-collaboration.

@jtpio
Copy link
Member

jtpio commented Oct 21, 2024

But we can likely fix it on this repo too.

Running jlpm why punycode -R gives the following:

├─ @jupyter/collaboration-extension@workspace:packages/collaboration-extension
│  ├─ @jupyter/docprovider@workspace:packages/docprovider (via ^3.0.0-rc.0)
│  └─ @jupyterlab/builder@npm:4.2.4 (via npm:^4.0.5)
│     ├─ source-map-loader@npm:1.0.2 [b82ed] (via npm:~1.0.2 [b82ed])
│     │  ├─ data-urls@npm:2.0.0 (via npm:^2.0.0)
│     │  │  └─ whatwg-url@npm:8.7.0 (via npm:^8.0.0)
│     │  │     └─ tr46@npm:2.1.0 (via npm:^2.1.0)
│     │  │        └─ punycode@npm:2.3.1 (via npm:^2.1.1)
│     │  └─ schema-utils@npm:2.7.1 (via npm:^2.7.0)
│     │     └─ ajv@npm:6.12.6 (via npm:^6.12.4)
│     │        └─ uri-js@npm:4.4.1 (via npm:^4.2.2)
│     │           └─ punycode@npm:2.3.1 (via npm:^2.1.0)
│     ├─ terser-webpack-plugin@npm:5.3.10 [b82ed] (via npm:^5.3.7 [b82ed])
│     │  └─ schema-utils@npm:3.3.0 (via npm:^3.1.1)
│     │     └─ ajv@npm:6.12.6 (via npm:^6.12.5)
│     ├─ webpack@npm:5.93.0 [b82ed] (via npm:^5.76.1 [b82ed])
│     │  ├─ schema-utils@npm:3.3.0 (via npm:^3.2.0)
│     │  └─ terser-webpack-plugin@npm:5.3.10 [b82ed] (via npm:^5.3.7 [b82ed])
│     └─ worker-loader@npm:3.0.8 [b82ed] (via npm:^3.0.2 [b82ed])
│        └─ schema-utils@npm:3.3.0 (via npm:^3.0.0)
│
├─ @jupyter/docprovider-extension@workspace:packages/docprovider-extension
│  ├─ @jupyter/docprovider@workspace:packages/docprovider (via ^3.0.0-rc.0)
│  └─ @jupyterlab/builder@npm:4.2.4 (via npm:^4.0.0)
│
├─ @jupyter/docprovider@workspace:packages/docprovider
│
└─ @jupyter/real-time-collaboration@workspace:.
   └─ eslint@npm:8.36.0 (via npm:~8.36.0)
      ├─ @eslint/eslintrc@npm:2.1.4 (via npm:^2.0.1)
      │  └─ ajv@npm:6.12.6 (via npm:^6.12.4)
      └─ ajv@npm:6.12.6 (via npm:^6.10.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants