Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #108 on branch 0.8.x (Creates document session) #113

Merged
merged 5 commits into from
Mar 5, 2023

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Mar 1, 2023

No description provided.

hbcarlos and others added 2 commits March 1, 2023 15:55
* Creates document session

* Uses translator

* Update jupyter_collaboration/handlers.py

* Create a new endpoint for document sessions, changes tranlator property and deprecates old endpoints

---------

Co-authored-by: David Brochart <david.brochart@gmail.com>
@hbcarlos hbcarlos added the bug Something isn't working label Mar 1, 2023
@hbcarlos hbcarlos self-assigned this Mar 1, 2023
@hbcarlos
Copy link
Member Author

hbcarlos commented Mar 1, 2023

The documentation test failed because we moved the documentation from jupyter_server_ydoc to jupyterlab-realtime-collaboration.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

jupyter_server_ydoc/app.py Show resolved Hide resolved
@hbcarlos hbcarlos requested a review from fcollonval March 3, 2023 10:35
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbcarlos

I bump already to 0.8.0 to avoid any trouble 😉

jupyter_server_ydoc/__init__.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (0.8.x@c42c27e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             0.8.x    #113   +/-   ##
=======================================
  Coverage         ?   0.00%           
=======================================
  Files            ?       3           
  Lines            ?     317           
  Branches         ?       0           
=======================================
  Hits             ?       0           
  Misses           ?     317           
  Partials         ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbcarlos hbcarlos merged commit a1c2411 into jupyterlab:0.8.x Mar 5, 2023
@hbcarlos hbcarlos deleted the doc_session branch March 5, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants