prevent navigation to external links

jupyterlab · Feb 16, 2022 · ea6e8b7 · ea6e8b7
1 parent 559bd72
commit ea6e8b7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/main.ts b/src/main/main.ts
@@ -190,10 +190,10 @@ app.on('ready', () => {
 });
 
 app.on("web-contents-created", (_event: any, webContents: WebContents) => {
-    // Prevent navigation to local links
+    // Prevent navigation to local links on the same page and external links
     webContents.on('will-navigate', (event: Event, navigationUrl) => {
         const jlabBaseUrl = `http://localhost:${appConfig.jlabPort}/`;
-        if (navigationUrl.startsWith(jlabBaseUrl) && navigationUrl.indexOf('#') !== -1) {
+        if (!(navigationUrl.startsWith(jlabBaseUrl) && navigationUrl.indexOf('#') === -1)) {
             console.warn(`Navigation is not allowed; attempted navigation to: ${navigationUrl}`);
             event.preventDefault();
         }