Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git config dialog is only displayed once #1353

Closed
jtpio opened this issue Oct 10, 2024 · 0 comments · Fixed by #1360
Closed

Git config dialog is only displayed once #1353

jtpio opened this issue Oct 10, 2024 · 0 comments · Fixed by #1360
Labels

Comments

@jtpio
Copy link
Member

jtpio commented Oct 10, 2024

Description

If you try to create a new commit and haven't set your git config (name and email address) yet, the dialog will be displayed on commit.

If you click on "OK" and then try to commit again, the dialog will not be shown.

Reproduce

First, make sure the git config is not set.

  1. Make a change
  2. Create a commit
  3. Click on "OK"
  4. The commit should fail
  5. Try to commit again
  6. The dialog is not displayed and the commit fails.

Expected behavior

The dialog should be displayed the second time.

Context

  • Python package version: 0.50.1
  • Extension version: 0.50.1
  • Git version: 2.43.0
  • Operating System and its version: All
@jtpio jtpio added the bug label Oct 10, 2024
@jtpio jtpio linked a pull request Oct 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant