User name changes in collaborative mode with no authentication

[davidbrochart]

Description

In JupyterLab master branch, with collaborative mode enabled, the name of the anonymous user periodically changes.

Reproduce

1. Install JupyterLab's master branch.
2. Launch JupyterLab with jupyter lab --dev-mode --collaborative.
3. Wait a couple of minutes.
4. See the name of the user change in the upper-right corner of the UI.

Expected behavior

The user name should not change.

[fcollonval]

@davidbrochart do you think it is linked to the websocket for the global awareness to be reopened?

[davidbrochart]

I don't think so, because it still happens after y-crdt/ypy-websocket#42.

[davidbrochart]

Also, it happens even when no document is opened.

[davidbrochart]

@davidbrochart do you think it is linked to the websocket for the global awareness to be reopened?

I think I didn't get your question, it could be linked to the global awareness yes.

[davidbrochart]

Actually, it is the backend which sends the new name on GET /api/me.

[davidbrochart]

It only happens when launching jupyter lab --ServerApp.token='' --ServerApp.password='', and seems to be because of jupyter-server/jupyter_server#1033.

[hbcarlos]

@davidbrochart, jupyter-server/jupyter_server#1076 was merged and released in jp-server v2.0.0rc5.
I guess this issue is now fixed? I can not reproduce it.

[hbcarlos]

Closing as fixed by jupyter-server/jupyter_server#1076.
I can see the backend always sending the same user identity, even when not using authentication.

[davidbrochart]

Yes, it is fixed.