Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error rendering buttons of the cell toolbar when deleting cells in a notebook #14380

Closed
jtpio opened this issue Apr 14, 2023 · 4 comments · Fixed by #15314
Closed

Error rendering buttons of the cell toolbar when deleting cells in a notebook #14380

jtpio opened this issue Apr 14, 2023 · 4 comments · Fixed by #15314

Comments

@jtpio
Copy link
Member

jtpio commented Apr 14, 2023

Description

Using 4.0.0b1 on Binder can lead to the following errors being logged in the dev tools console:

Error rendering buttons of the cell toolbar:  TypeError: t.layout is null

Reproduce

  • Create a notebook
  • Create cells
  • Select cells
  • Delete them with the cut toolbar item
jupyterlab-4-delete-cells-dev-tools-error.mp4

Expected behavior

No error in the dev tools console.

Context

@jtpio jtpio added bug status:Needs Triage Applied to new issues that need triage labels Apr 14, 2023
@jtpio jtpio added this to the 4.0.0 milestone Apr 14, 2023
@krassowski krassowski added tag:Release Blocker A must-have bug for the milestone to which it is tagged and removed status:Needs Triage Applied to new issues that need triage labels Apr 14, 2023
@krassowski
Copy link
Member

Switching cell type produces a similar error:

Error rendering buttons of the cell toolbar:  TypeError: Cannot read properties of null (reading 'insertWidget')

or in Firefox:

Error rendering buttons of the cell toolbar:  TypeError: can't access property "insertWidget", t.layout is null

switching cell type

@JasonWeill
Copy link
Contributor

May be fixed if #14139 is done

@JasonWeill JasonWeill removed the tag:Release Blocker A must-have bug for the milestone to which it is tagged label Apr 19, 2023
@JasonWeill JasonWeill modified the milestones: 4.0.0, 4.0.x Apr 19, 2023
@JasonWeill
Copy link
Contributor

As discussed at the JupyterLab weekly meeting, this is a bug we should fix in 4.0.x, but is not a release blocker for 4.0.0.

@krassowski
Copy link
Member

I encountered something similar while porting the vim extension; it appears that when cell type is being switch the activeCellChanged signal emits with the old cell which is already disposed. It should not do that IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants