Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_config.json should support json5 #377

Closed
mlucool opened this issue Feb 24, 2023 · 2 comments · Fixed by #388
Closed

page_config.json should support json5 #377

mlucool opened this issue Feb 24, 2023 · 2 comments · Fixed by #388

Comments

@mlucool
Copy link
Contributor

mlucool commented Feb 24, 2023

Problem

Similar to overrides, page_config.json should also support json5 so that comments can be added.

Proposed Solution

All json configs should always support json5. Maybe we add a common codepath to enforce this? I.e. instead of doing something like this we refactor this to be reused.

@welcome
Copy link

welcome bot commented Feb 24, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@peytondmurray
Copy link
Contributor

I'm happy to take this on! Refactoring now to allow json5 everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants