Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTD to include multiple versions of Lumino #336

Closed
afshin opened this issue Aug 8, 2022 · 11 comments
Closed

Update RTD to include multiple versions of Lumino #336

afshin opened this issue Aug 8, 2022 · 11 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Please work on this if you are interested maintenance Dependencies, build, technical debt, etc.
Milestone

Comments

@afshin
Copy link
Member

afshin commented Aug 8, 2022

The Lumino readthedocs.io site should support both Lumino 1 and Lumino 2 docs and needs a re-visit for maintenance.

@afshin afshin added documentation Improvements or additions to documentation help wanted Please work on this if you are interested maintenance Dependencies, build, technical debt, etc. labels Aug 8, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 8, 2022
@afshin afshin added this to Lumino 2 Aug 8, 2022
@afshin afshin moved this to Todo in Lumino 2 Aug 8, 2022
@gabalafou
Copy link
Contributor

I need to familiarize myself more with Read the Docs, so I'm willing to try to figure out how to

  • upgrade current Read the Docs
  • add version support

But I don't think I have enough of the big picture of Lumino to make content/copy changes and contributions here.

@afshin
Copy link
Member Author

afshin commented Aug 10, 2022

make content/copy changes and contributions here

Don't worry, the content for now is all contained within doc strings, so if you can generate an RTD page that shows the API documentation for the current version and the previous version, we are good.

@blink1073
Copy link
Contributor

It should be controllable by having an active "Version" for the 1.x branch. See JupyterLab for example:

image

@blink1073
Copy link
Contributor

@gabalafou, what is your ReadTheDocs username?

@gabalafou
Copy link
Contributor

I didn't have a Read the Docs username before, but it is now the same as my GitHub username: gabalafou.

@blink1073
Copy link
Contributor

Great, you should have an invite now!

@gabalafou
Copy link
Contributor

With #354 merged, I went ahead and made the following changes in the Read The Docs settings:

  • Deactivated version stable
  • Activated version 1.x
  • Set latest to point to main instead of master.
    • Previously it was blank. The RTD UI says, "Leave empty to use the default value for your VCS (eg. trunk or master)." However, the versions page was still showing latest pointing to master until I set it explicitly to main under Admin > Advanced Settings > Default branch.

I discussed the desired final config with @afshin on Tuesday, and the above changes reflect that conversation. He said that he envisioned just two RTD versions: 1.x and latest.

You should now be able to see all of these changes (RTD settings plus code changes from #354) at https://lumino.readthedocs.io.

Therefore, I'm going to close this issue for now.

Repository owner moved this from in progress to done in Lumino 2 Aug 19, 2022
@gabalafou
Copy link
Contributor

gabalafou commented Aug 19, 2022

Oh, I almost forgot: a few things before we completely move on from this issue. I created several follow-up issues from this work:

@fcollonval
Copy link
Member

  • Deactivated version stable

I would prefer to keep it. It is a good practice to provide a default endpoint that people can bookmark.

@gabalafou
Copy link
Contributor

@afshin can you respond to @fcollonval's comment above?

I was just following your guidance when setting up RTD to just have latest and 1.x but not stable.

Reminder that stable points (I think) to whichever year-month-day-format tag is the latest in Lumino repo, which at the time of this writing is v2022.8.22-alpha.1, I think (although I'm curious whether RTD will pick up a tag with an -alpha suffix as stable).

@fcollonval
Copy link
Member

from documentation We only consider non pre-releases for the stable version of your documentation.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation help wanted Please work on this if you are interested maintenance Dependencies, build, technical debt, etc.
Projects
No open projects
Status: done
Development

No branches or pull requests

4 participants