Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect from GitHub pages to RTD #362

Open
krassowski opened this issue Aug 21, 2022 · 6 comments
Open

Add redirect from GitHub pages to RTD #362

krassowski opened this issue Aug 21, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@krassowski
Copy link
Member

In #358 the second copy of docs (under https://jupyterlab.github.io/lumino) was disabled. It seems that search engines seemed to prefer https://jupyterlab.github.io/lumino and these are dead links now.

It would be great to have a redirect to not loose the existing links and positioning in search engines. I explored options for doing so while writing up the issue which resulted in a commit on main branch (seriously GitHub, now actions from GUI can result in a commit without any button which says "commit"?) - sorry about this.

@krassowski
Copy link
Member Author

It seems that the redirect is working for the main address: https://jupyterlab.github.io/lumino but old links like https://jupyterlab.github.io/lumino/signaling/interfaces/isignal.html show 404 on RTD as the URL structure is different now.

We could manually setup redirects in the RTD interface, e.g. from signaling/index.html to en/latest/api/modules/signaling.html for each of the packages (and later once search engines caught up disable these redirects).

@krassowski
Copy link
Member Author

krassowski commented Aug 21, 2022

Happy to add the redirects manually if I can get the RTD access. Currently all three top results in Google give 404 - a bit annoying since I am still learning to navigate the refreshed API docs.

  1. https://jupyterlab.github.io/lumino/signaling/index.html (redirect to https://lumino.readthedocs.io/signaling/index.html)
  2. https://lumino.readthedocs.io/en/latest/api/signaling/globals.html
  3. https://lumino.readthedocs.io/en/latest/api/signaling/index.html

The working link (not yet indexed) is: https://lumino.readthedocs.io/en/latest/api/modules/signaling.html

Screenshot from 2022-08-21 18-13-40

@blink1073
Copy link
Contributor

What is your RTD username?

@krassowski
Copy link
Member Author

krassowski. Thanks!

@blink1073
Copy link
Contributor

Invite sent, thank you!

@krassowski
Copy link
Member Author

Thank you, I added redirects for (1) and (3) now.

@afshin afshin added documentation Improvements or additions to documentation enhancement New feature or request and removed enhancement New feature or request status:Needs Triage labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants