Fix sluggish tab dragging in the tab bar. #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typo in commit 45c6f21 prevented a rule from applying to tab elements. The effect is that a CSS transition is always applied to tabs when dragging them, and dragging tabs inside the tab bar is less responsive.
|
Oh, wow, thanks for fixing this typo. |
jasongrout
approved these changes
Nov 2, 2020
|
Thanks for the quick review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo from commit 45c6f21.
If you need to reproduce the issue, you can roll back an application with a dock panel to widgets@1.9.7 and default-theme@0.1.8, and compare the responsiveness of the tab bar to an application built at the latest versions.