-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we depend on the RTC package by default for 4.0.0? #177
Comments
Not shipping it by default will
Shipping it will
|
Right now we are focused on 4.0, so I haven't given much though about what we would focus on after the 4.0 launch. At the same time, I think that the output bug (outputs sent while the frontend is disconnected are lost) is one of the most painful parts of Jupyter for users and would love to see us tackle it during the 4.x release cycle. Given that, I am probably in favor of shipping and enabling it as the default for JupyterLab 4.0. Another reason to do this is that it will ensure that we discover and fix any remaining issues with RTC or the server side storage of files. |
In my opinion, we should not depend on the RTC extension by default. JupyterLab is used in various scenarios, and for now, the JupyterLab-RTC extension only covers one scenario; multiple users connecting to one server where everything runs on the same machine, kernels, file system, etc. There could be other use cases like:
All those use cases can be implemented by different extensions, and users can choose what fits best for them. |
At a high level, i feel Installing the flagship
What it probably doesn't need is:
In the specific case of RTC: as discussed on the most recent JupyterLab call, @fperez called out one of the ages-old issues of multiple browser tabs sharing a document's content. If there is a way, such as a If the ydoc-based server is required to support even two browser tabs on the same computer from the same running server process, then it should probably be depended on by default. As a greedy aside: describing the requisite lightweight "serverless" API would enable other bespoke clients, like JupyterLite, to follow the pattern to be backed by a non-bespoke backend server (e.g. XMPP, dat, etc.) But I digress. So my ideal experiences might be described like: pip install notebook
jupyter notebook
pip install jupyterlab jupyter-server-local-collaboration
jupyter lab
conda install -c conda-forge jupyterlab-devtools # brings in notebook and -collaborative
jupyter lab
|
As another side note regarding installability, as noted on gitter where the breaking 3.6 release is already affecting downstreams not even being able to build, with attendant mysterious When used as part of a In addition to the above, there should probably be an even smaller component with just enough to run |
If it weren't for @bollwyvl helping me out, I would have given up adding a bugfix to ipyleaflet (jupyter-widgets/ipyleaflet#1099). Not to complain, just to share real-life feedback, since we probably don't hear 90+% of these friction issues. |
BTW @maartenbreddels - that means that ipyleaflet currently can't be installed in a JLab alongside 3.6, correct? (or as of the next ipyleaflet release with that change merged)? |
It can be installed, nothing changes for users, this is only the build requirement. Runtime dependencies are unchanged. |
Since the JupyterLab 4 final release is approaching and JupyterLab is currently in rc1, it looks like the general feeling would be to not depend on |
Closing as JupyterLab 4 does not depend on |
Problem
The work to make Real Time Collaboration optional through a package has started.
When discussing where that code should be hosted on GitHub on the weekly call, the question of should it be or not a default dependency was raised. This issue is for discussing that point.
The text was updated successfully, but these errors were encountered: